[Bug 832804] Review Request: axion - Open Source Java Database

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=832804



--- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> Issues
> =======
> It seems that fedora-review is badly confused here for some reason. I'm
> leaving its comments for reference.
> 
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://fedoraproject.org/wiki/Packaging:Guidelines
> 
> It does install properly, when #832803 is installed.
> 
> - Packages have proper BuildRequires/Requires on jpackage-utils
> 
> They seem to have.
> 
> - POM files have correct Maven mapping
>   Note: Old style Maven package found, no add_maven_depmap calls found but
> POM
>   files present
>   See: https://fedoraproject.org/wiki/Packaging:Java#add_maven_depmap_macro
> 
> %mvn_install is used, so things seem fine.
> 
> - If (and only if) the source package includes the text of the license(s) in
>   its own file, then that file, containing the text of the license(s) for the
>   package is included in %doc.
>   Note: Cannot find LICENSE.txt in rpm(s)
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
> 
> Bogus.
> 

> Things look kosher, only the license is unclear.

Spec URL: http://gil.fedorapeople.org/axion.spec
SRPM URL: http://gil.fedorapeople.org/axion-1.0-2.fc20.src.rpm

- fix license field

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]