https://bugzilla.redhat.com/show_bug.cgi?id=987558 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to gil cattaneo from comment #3) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Fedora 19 is EOL, so '%if %{?fedora} > 20' conditional could be removed. > yes, i know this is for Fedora 20 only. After upload the package, i will > remove this check Argh, it's > 20, not >= 20. Please disregard my comment. > > I'd suggest adding this to have less directories: > > # Use the same directory of the main package for subpackage licence and docs > > %global _docdir_fmt %{name} > > this would make it useless > "License file installed when any subpackage combination is installed." > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#Subpackage_Licensing Those files would be co-owned by multiple binary packages, so the files would still be there when at least one of them is installed. The only difference would be less directories and less duplicated files in the system. Just a suggestion though. > > Everything looks fine. I have one question: is the separate > > geronimo-txmanager binary package needed? It seems as if it could be folded > > into geronimo-transaction. > > i prefer separate each artifacts in its own package. > currently is considered a best practice. ask in the fedora-java irc channel > for more info OK. Package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review