https://bugzilla.redhat.com/show_bug.cgi?id=987558 --- Comment #3 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Fedora 19 is EOL, so '%if %{?fedora} > 20' conditional could be removed. yes, i know this is for Fedora 20 only. After upload the package, i will remove this check > I'd suggest adding this to have less directories: > # Use the same directory of the main package for subpackage licence and docs > %global _docdir_fmt %{name} this would make it useless "License file installed when any subpackage combination is installed." https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing > Everything looks fine. I have one question: is the separate > geronimo-txmanager binary package needed? It seems as if it could be folded > into geronimo-transaction. i prefer separate each artifacts in its own package. currently is considered a best practice. ask in the fedora-java irc channel for more info thanks -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review