https://bugzilla.redhat.com/show_bug.cgi?id=1194798 Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #19 from Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [-]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/GeoIP(geoipupdate- cron6, GeoIP-data) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: GeoIP-GeoLite-data-2015.04-1.fc23.noarch.rpm GeoIP-GeoLite-data-extra-2015.04-1.fc23.noarch.rpm GeoIP-GeoLite-data-2015.04-1.fc23.src.rpm GeoIP-GeoLite-data.noarch: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.noarch: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.noarch: W: no-documentation GeoIP-GeoLite-data.noarch: W: dangerous-command-in-%preun rm GeoIP-GeoLite-data.noarch: W: dangerous-command-in-%posttrans mv GeoIP-GeoLite-data-extra.noarch: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data-extra.noarch: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data-extra.noarch: W: no-documentation GeoIP-GeoLite-data.src: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.src: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation 3 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- GeoIP-GeoLite-data-extra (rpmlib, GLIBC filtered): GeoIP-GeoLite-data GeoIP-GeoLite-data (rpmlib, GLIBC filtered): /bin/sh Provides -------- GeoIP-GeoLite-data-extra: GeoIP-GeoLite-data-extra GeoIP-GeoLite-data: GeoIP-GeoLite-data GeoIP-data geoip-geolite Source checksums ---------------- http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz : CHECKSUM(SHA256) this package : aa005e191fff2b1e31974b79feec739ddaa35461cadc04733fff35d695498651 CHECKSUM(SHA256) upstream package : aa005e191fff2b1e31974b79feec739ddaa35461cadc04733fff35d695498651 http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz : CHECKSUM(SHA256) this package : fbad6e68012b4b1b170606325d68afa3053955c8cdf29b53a88d0dc2d18b1acd CHECKSUM(SHA256) upstream package : fbad6e68012b4b1b170606325d68afa3053955c8cdf29b53a88d0dc2d18b1acd http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz : CHECKSUM(SHA256) this package : 33104eb35340c97227ea93f7ba1c84c38742a4f8adea23a3201350e9bd918795 CHECKSUM(SHA256) upstream package : 33104eb35340c97227ea93f7ba1c84c38742a4f8adea23a3201350e9bd918795 http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz : CHECKSUM(SHA256) this package : 71245e34e80e45257183eaab5392fbb2bd84c8e1757d9649bc22e39faff4e64f CHECKSUM(SHA256) upstream package : 71245e34e80e45257183eaab5392fbb2bd84c8e1757d9649bc22e39faff4e64f http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNum.dat.gz : CHECKSUM(SHA256) this package : 0be44352fd85e9d6efd448ac21bb8fb705c54246955691f18383e8e19b5a2d22 CHECKSUM(SHA256) upstream package : 0be44352fd85e9d6efd448ac21bb8fb705c54246955691f18383e8e19b5a2d22 http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNumv6.dat.gz : CHECKSUM(SHA256) this package : f21703899723562b8a206c6de506a156831655345ce7d7a7180e8a41a20db3e5 CHECKSUM(SHA256) upstream package : f21703899723562b8a206c6de506a156831655345ce7d7a7180e8a41a20db3e5 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -o --no-cleanup-after -r fedora-rawhide-x86_64 --yum -b 1194798 Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review