https://bugzilla.redhat.com/show_bug.cgi?id=1208738 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #16 from Raphael Groner <projects.rg@xxxxxxxx> --- Still some open issues I would like to see fixed in the final package: - ASL 2.0 is meant for vera.ctest but not for vera.cmake (there's no such named file!) as you mention it in the comment, though I am not sure if this license includes then also the full source for the tests. Please be careful here and better ask upstream if in doubt. That can be pointless since it is valid only for the tests and they do not go into the compiled RPM. https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#Multiple_licensing_situations - You can add "BuildArch: noarch" and "Requires: cmake" (or cmake28 respectively) to the devel subpackage because it does not include by itself any arch dependent binaries and is useful only with cmake at hand. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review