[Bug 1207570] Review Request: adobe-source-han-sans-tw-fonts - Adobe font family for Traditional Chinese

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1207570

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:
+ Package built fine in mock F23 x86_64

+ rpmlint on generated rpms gave output
adobe-source-han-sans-tw-fonts.noarch: W: self-obsoletion
adobe-source-han-sans-twhk-fonts obsoletes adobe-source-han-sans-twhk-fonts
adobe-source-han-sans-tw-fonts.src:24: W: unversioned-explicit-provides
adobe-source-han-sans-twhk-fonts
adobe-source-han-sans-tw-fonts.src:25: W: unversioned-explicit-obsoletes
adobe-source-han-sans-twhk-fonts
adobe-source-han-sans-tw-fonts.src: W: invalid-url Source0:
SourceHanSansTW-1.001.zip
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> These new to be fixed as suggested below

+ Source verified with upstream source as (sha256sum)
tarball in srpm:
d9df92206902eb7942823e82360609f06cbee23056689a7d9c5c98aff394c8ce
tarball generated:
5e71a0aef865971086abea34c8ce7717393a8a9cb96b95ad74dae5d3aa0909d3

=> Though both have different hash value but same files its because of binary
files archiving.

+ License is "ASL 2.0" which is correct and its text is in LICENSE.txt file

+ fontconfig file is carried from old package adobe-source-han-sans-twhk-fonts


Suggestions:
1) Package renames requires a clean upgrade path. Please read
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

your package need to have following changes
=====================================
@@ -5,7 +5,7 @@

 Name:           adobe-source-han-sans-tw-fonts
 Version:        1.001
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Adobe OpenType Pan-CJK font family for Traditional Chinese

 License:        ASL 2.0
@@ -21,8 +21,8 @@
 BuildRequires:  fontpackages-devel
 Requires:       fontpackages-filesystem

-Provides:       adobe-source-han-sans-twhk-fonts
-Obsoletes:      adobe-source-han-sans-twhk-fonts
+Provides:       adobe-source-han-sans-twhk-fonts = %{version}-%{release}
+Obsoletes:      adobe-source-han-sans-twhk-fonts <= 1.001-2

 %description
 Source Han Sans is a sans serif Pan-CJK font family 
@@ -62,8 +62,7 @@


 %_font_pkg -f %{fontconf} *.otf
-
-%doc LICENSE.txt
+%license LICENSE.txt


 %changelog
===========================================

Submit these changes in new srpm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]