https://bugzilla.redhat.com/show_bug.cgi?id=1210969 Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Docs Contact| |pingou@xxxxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> --- * Using the sources from upstream: SRPM: 68fd192e64a22a69d445a74d84da640cb2314e9571114836864a7b5c06d1454d Upstream: 68fd192e64a22a69d445a74d84da640cb2314e9571114836864a7b5c06d1454d * License MIT is valid, present in the sources and installed correctly in the spec file * Spec file looks good ! rpmlint output can be improved: python-munch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/munch/__init__.py 0644L /usr/bin/env python3-munch.noarch: E: non-executable-script /usr/lib/python3.4/site-packages/munch/__init__.py 0644L /usr/bin/env 3 packages and 0 specfiles checked; 2 errors, 0 warnings. Maybe https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries could help After this I'll approve the review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review