[Bug 1210990] Review Request: qt5-qtwebchannel - Qt5 WebChannel component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1210990

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
$ rpmlint qt5-qtwebchannel qt5-qtwebchannel-devel
qt5-qtwebchannel.x86_64: W: incoherent-version-in-changelog 5.4.0-1
['5.4.1-1.fc22', '5.4.1-1']
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libQt5Network.so.5
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libpthread.so.0
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libm.so.6
qt5-qtwebchannel.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libQt5WebChannel.so.5.4.1 /lib64/libgcc_s.so.1
qt5-qtwebchannel-devel.x86_64: W: only-non-binary-in-usr-lib
qt5-qtwebchannel-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 7 warnings.

mostly harmless

naming: ok, matches standard naming of other qt5- modules in distro

license: ok

sources: ok
$ md5sum *.xz
bb914134c164c6758a0074748cc678ff  qtwebchannel-opensource-src-5.4.1.tar.xz

builds/installs: ok

macros: ok

scriptlet: ok

looks like the qt5-qtwebsocket build dependency is optional and only for some
examples, but using it here is mostly harmless.  Probably worth adding a .spec
comment about this, in case it helps bootstrapping new archs.


Otherwise, thanks, looks good, APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]