[Bug 921134] Review Request: boost148 - The free peer-reviewed portable C++ source libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=921134



--- Comment #18 from Denis Arnaud <denis.arnaud_fedora@xxxxxxx> ---
Spec URL: http://denisarnaud.fedorapeople.org/boost/boost148/boost148.spec
SRPM URL:
http://denisarnaud.fedorapeople.org/boost/boost148/boost148-1.48.0-5.fc20.src.rpm


EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462960
EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9462986 (the build
is fine, but the Koji build process fails at the end because of a lack of
resource)

===================
(In reply to Rex Dieter from comment #16)
> May be worth reviewing later commits/fixes to base boost-1.48.0 pkg up to:
> http://pkgs.fedoraproject.org/cgit/boost.git/commit/
> ?id=dcde8a75575cb4c256ea982593c9710ac16b022c

Done. Integrated all the missing patches.

> 1 MUST fix missing -math dep in main metapackage and missing scriptlets
> fixed in:
> http://pkgs.fedoraproject.org/cgit/boost.git/commit/
> ?id=8aad81e67cbfd196e040449b0bf2cd854642c447

Done


> 2.  SHOULD consider using %{name} and %{?_isa} macros in place of
> hard-coding boost148 in dependencies. imo, that simplifies things keeps
> things consistent.  for example, replace
> Requires: boost148-chrono = %{version}-%{release}
> with
> Requires: %{name}-chrono%{?_isa} = %{version}-%{release}

Done


Did not check yet whether the fix for ppc64 works.
=======================

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]