https://bugzilla.redhat.com/show_bug.cgi?id=1161483 Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.ploumistos@xxxxxxxxx --- Comment #2 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> --- Hello, This is an unofficial review. I don't know if anyone more qualified than me will take issue with the source (re)packaging, which gives rpmlint something to complain about, but the rationale seems obvious. The patch is also pretty much self-explanatory, perhaps someone would prefer a more explicit comment someplace. There does seem to be an issue with the licenses though: BSD (2 clause) -------------- o3dgc/src/o3dgc_common_lib/inc/o3dgcArithmeticCodec.h o3dgc/src/o3dgc_common_lib/src/o3dgcArithmeticCodec.cpp MIT/X11 (BSD like) ------------------ o3dgc/js/o3dgc.js o3dgc/src/o3dgc_common_lib/inc/o3dgcAdjacencyInfo.h o3dgc/src/o3dgc_common_lib/inc/o3dgcBinaryStream.h o3dgc/src/o3dgc_common_lib/inc/o3dgcCommon.h o3dgc/src/o3dgc_common_lib/inc/o3dgcDVEncodeParams.h o3dgc/src/o3dgc_common_lib/inc/o3dgcDynamicVector.h o3dgc/src/o3dgc_common_lib/inc/o3dgcFIFO.h o3dgc/src/o3dgc_common_lib/inc/o3dgcIndexedFaceSet.h o3dgc/src/o3dgc_common_lib/inc/o3dgcSC3DMCEncodeParams.h o3dgc/src/o3dgc_common_lib/inc/o3dgcTimer.h o3dgc/src/o3dgc_common_lib/inc/o3dgcTriangleFans.h o3dgc/src/o3dgc_common_lib/inc/o3dgcVector.h o3dgc/src/o3dgc_common_lib/src/o3dgcTools.cpp o3dgc/src/o3dgc_common_lib/src/o3dgcTriangleFans.cpp o3dgc/src/o3dgc_decode_lib/inc/o3dgcDynamicVectorDecoder.h o3dgc/src/o3dgc_decode_lib/inc/o3dgcSC3DMCDecoder.h o3dgc/src/o3dgc_decode_lib/inc/o3dgcTriangleListDecoder.h o3dgc/src/o3dgc_decode_lib/src/o3dgcDynamicVectorDecoder.cpp o3dgc/src/o3dgc_encode_lib/inc/o3dgcDynamicVectorEncoder.h o3dgc/src/o3dgc_encode_lib/inc/o3dgcSC3DMCEncoder.h o3dgc/src/o3dgc_encode_lib/inc/o3dgcTriangleListEncoder.h o3dgc/src/o3dgc_encode_lib/src/o3dgcDynamicVectorEncoder.cpp o3dgc/src/test/src/main.cpp Unknown or generated -------------------- o3dgc/install/run.py o3dgc/js/index.php o3dgc/js/three.min.js You need to specify all licenses in the spec file and it would be nice to sort files in the %files section by their license. See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios I am away from my main system and I don't have koji setup here, so I could only test locally for x86_64. Have you tried building the package for other architectures? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review