[Bug 1161099] Review Request: nodejs-wrappy - Callback wrapping utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1161099



--- Comment #11 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
May I know how do you see the package is broken(missing macros)??

Looking at your spec it looks like you wrote it exclusively for EPEL6.

In Fedora we don't need Group tag, even we don't need it on EPEL6.

You changed the source to npm registry. I really don't like those npm registry
sources where I see their upstreams (mostly github sources) contain more
information(like docs, test files). So better to use github sources always.

Also, there are no dependencies to get included so adding %nodejs_symlink_deps
does not make any difference.

I don't know why you have added scl macros in this spec file.

The only important thing to add/change in spec is to have conditional BR:
%if 0%{?enable_tests}
BuildRequires:  npm(tap)
%endif

and enable the tests.
%check
%if 0%{?enable_tests}
%{nodejs_symlink_deps} --check
tap test/*.js
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]