https://bugzilla.redhat.com/show_bug.cgi?id=1190269 Greg Swift <gregswift@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(karlthered@gmail. | |com) --- Comment #6 from Greg Swift <gregswift@xxxxxxxxx> --- (In reply to Haïkel Guémar from comment #5) > The main difference is likely to be that I used mock to rebuild the package > so in a minimal chrooted environment. I had built it in a mock environment (specifically via a local mockchain as well as in copr). I thought i had run installs off of it. Looking back now that package is not clean, so i'm not sure what happened with that testing. I should have realized this when asking the question before. Sorry. > Remains few issues reported by rpmlint. > * Summary of python-barbican ends with a dot, drop it done > * logrotate file should be marked as %config done > * why barbican-api.conf is in openstack-barbican-worker subpackage ? the worker uses this config file right now. refactoring to where it just requires the -api. which is annoying but less obtuse. > * I would create a barbican-api subpackage done, but still leaves barbican-api.conf in worker subpackage until they can separate that out. > * the pbr patch is still there but not needed since there's a requirement on > pbr you said post-juno. Its still there, for juno. There are several juno specific bits in there. When one part goes, it all does. > * no version in changelog. done URL for the item in my git repo: https://github.com/gregswift/barbican-spec/blob/juno/openstack-barbican.spec Updated info: Spec URL: http://nytefyre.net/rpms/openstack-barbican.spec SRPM URL: http://nytefyre.net/rpms/openstack-barbican-2014.2-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review