[Bug 1208904] Review Request: python-jenkins-job-builder - Manage Jenkins jobs with YAML

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1208904



--- Comment #3 from Colin Walters <walters@xxxxxxxxxx> ---
(In reply to Ken Dreyer from comment #2)
> Hi Colin, would you be ok with me renaming this to simply
> "jenkins-job-builder" ? I noticed dcaro's package was named this way, and I
> think it makes more sense.

This actually leads to a question I had - right now this package includes both
a Python library *and* a binary.

Are there any other packages that might depend on the library code?  If not,
that would argue for moving the library into a private directory (e.g.
/usr/lib/jenkins-job-builder), and setting PYTHONPATH (or changing sys.path)
inside the binary script.

I realize this approach isn't common among Python programs, but I believe that
making a shared library shouldn't be the default - only libraries which are
"stable" should be public.

> If you indicate your approval for this change, I'll rename the bug title and
> put in the SCM admin request.

The above all said...I'm not opposed to a rename.  You'll find Python packages
whose primary interface is an executable in Fedora that go both ways.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]