[Bug 1199829] Review Request: gtk-theme-config - Little tool to configure GTK theme colors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1199829



--- Comment #9 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
I have looked a bit more closely at the Makefile included with the project
(which is a bit of a mess). Really, I think the best way to set CFLAGS reliably
is to break the build vala compilation down into two steps - first run valac
with the -c option to produce the c code, and then call gcc to compile the
c-code. You'll need to patch the makefile to do this. Presently the way CFLAGS
is used to provide options to the vala compiler is sub-optimal.

I would urge you to work with the upstream maintainer to move to a sensible
build system (autotools or cmake) rather than this handcrafted and buggy
Makefile.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]