https://bugzilla.redhat.com/show_bug.cgi?id=1208701 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST --- Comment #8 from Raphael Groner <projects.rg@xxxxxxxx> --- Thanks for the review! (In reply to gil cattaneo from comment #7) > Please, correct or remove this definition: > > # define sitearch for EPEL > %{!?python3_sitearch: %global python3_sitearch %(%{__python2} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} There's currently no Python3 for EPEL. I'll remove this wrong line. You're right, thanks for the hint. (In reply to gil cattaneo from comment #5) > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 17 files have unknown license. > Detailed output of licensecheck in /home/gil/1208701-jpype-py3/review- > jpype-py3/licensecheck.txt > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/cygwin/jni_md.h GPLv2 > jpype-py3-ca6fc96a76d430c753b56ec2a4ed2a3eced0dac3/native/python/include/capsulethunk.h GPL/Python … > [?]: Package contains no bundled libraries without FPC exception. > see above > jni_md.h is part of JDK > capsulethunk.h is part of Python https://hg.python.org/cpython/file/b4cbecbc0781/Doc/includes/capsulethunk.h As those both files are GPL'ed, I guess there's no more action needed. Is that right, please confirm. > [x]: Latest version is packaged. > the "real" version is "0.5.5.2", maybe, you should use > Version: 0.5.5.2 > Release: 0.1.%{date}git%{shortcommit}%{?dist} > * Thu ... - 0.5.5.2-0.1.20150202gitca6fc96 Will be fixed. > [?]: Useful -debuginfo package or justification otherwise. Not sure how java provides extra debuginfo, rpmbuild must find any if there. > [!]: Reviewer should test that the package builds in mock. rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9417336 ==> OK > [?]: Python eggs must not download any dependencies during the build process. Copr build does not allow any network access and is success: https://copr.fedoraproject.org/coprs/raphgro/playground/build/84763/ > [?]: %check is present and all tests pass. (In reply to Raphael Groner from comment #1) > Open issue: How to run the provided tests/testsuite.py without installing > the jpype module what is assumed in the test? Still thinking about using that testsuite.py somehow for %check … > jpype-py3.src: E: specfile-error sh: line 0: fg: no job control > i dont understand this error ... You build for i386. Not tried yet by myself. Maybe an explanation for failure. But all x86_64 builds work (local rpmbuild f21, koji scratch rawhide, copr f20+f21+rawhide). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review