[Bug 1057874] Review Request: libspf2 - Implementation of the Sender Policy Framework for SMTP authorization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1057874

Matt Domsch <matt_domsch@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(matt_domsch@dell. |
                   |com)                        |



--- Comment #13 from Matt Domsch <matt_domsch@xxxxxxxx> ---
There are no static libraries included in the -devel package.

I have added %{?_isa} to the -devel package Requires.

We do not need to add %{?_isa} to other subpackage Requires, they will be
handled automatically by rpmbuild.

I believe the scriptlets are sane, they only run ldconfig and manage
adding/removing to alternatives.

libspf2-1.2.10-3.gitd57d79fd.fc21.x86_64.rpm and related files
posted to https://domsch.com/linux/fedora/libspf2/ with the only change being
to add %{?_isa} to the -devel package Requires.
diff -urNp 2/libspf2.spec 3/libspf2.spec
--- 2/libspf2.spec      2015-04-04 17:00:15.000000000 -0500
+++ 3/libspf2.spec      2015-04-05 15:08:58.000000000 -0500
@@ -4,9 +4,9 @@
 # Each change to the spec requires a bump to version/release of both library
and perlmod
 %global git d57d79fd
 %global library_version 1.2.10
-%global library_release 2.git%{git}%{?dist}
+%global library_release 3.git%{git}%{?dist}
 %global perlmod_version 0.01
-%global perlmod_release 6.git%{git}%{?dist}
+%global perlmod_release 7.git%{git}%{?dist}

 # Set to 1 for a compat-libspf2 package
 %global compat 0
@@ -87,7 +87,7 @@ Summary:      Development tools needed to bui
 Group:         Development/Libraries
 Version:       %{library_version}
 Release:       %{library_release}
-Requires:      %{name} = %{version}-%{release}
+Requires:      %{name}%{?_isa} = %{version}-%{release}

 %description devel
 The libspf2-devel package contains the header files and static
@@ -281,6 +281,9 @@ exit 0
 %endif

 %changelog
+* Sun Apr  5 2015 Matt Domsch <mdomsch@xxxxxxxxxx> - 1.2.10-3
+- update for review comments
+
 * Sat Apr  4 2015 Matt Domsch <mdomsch@xxxxxxxxxx> - 1.2.10-2
 - update to upstream 1.2.10+git
 - update automake / autoconf for Fedora 21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]