https://bugzilla.redhat.com/show_bug.cgi?id=1207946 --- Comment #5 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Raphael Groner from comment #4) > > - Are you really sure to rename this package in Fedora to javawriter in > contrast to the upstream name javapoet? How can it be found with the classic > name as guessed from upstream? Okay, I can see the recent github releases > are named javawriter. Maybe we should use the younger fork of google. > [?]: Package is named according to the Package Naming Guidelines. > the library was originally appointed javawriter and recently has been renamed javapoet. the two libraries are incompatible. the fork of google dagger (https://github.com/google/dagger) uses as you said their fork javawriter ... for me ... a crap ... until i prefer to use the original (Square) release for me there aren't contrast with upstream > > Square's Javawriter > > This is a fork of Square's Javapoet intended as a staging ground for changes > > originating from inside google. While it may vary from Square's, the intention > > is that all changes end up merged into to Square's repository, and that this > > fork will only vary temporarily while change is in process. Generally, unless > > you are depending on features not yet merged you should depend on square's > > version. We have no plans to do releases, though this fork will publish > > snapshots on successful merges. > https://github.com/google/javapoet/blob/master/README.md For now i prefer use the Square library and not have > - Include also %doc CONTRIBUTING.md into %files cause this file tells to > sign a special contract about copyright etc. to be allowed for contribution > at upstream. Done > Maven: > [?]: If package contains pom.xml files install it (including depmaps) even > when building with ant > > ==> Can not check magical maven logic. listed in .mfiles* > [?]: %check is present and all tests pass. > > ==> Could those test/**/*Test.java files be used to run a short test? Why is > it broken? The all test suite use fest-assert-core:2.0M8 and i tried to remove some files but at the end not have one valid *Test.java file for this scope > > # Unavailable test deps: org.easytesting:fest-assert-core:2.0M8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review