https://bugzilla.redhat.com/show_bug.cgi?id=1015868 Raphael Groner <projects.rg@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |FutureFeature Priority|unspecified |medium CC| |projects.rg@xxxxxxxx Version|21 |rawhide Severity|unspecified |medium Red Hat Bugzilla <bugzilla@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|Bug Fix |Enhancement --- Comment #9 from Raphael Groner <projects.rg@xxxxxxxx> --- This is a short informal review of your spec file with all my comments as SHOULD only. * Please use consistently the provided macros, also for the upstream project name. You can use the %{url} macro to shorten additional links. > URL: https://github.com/hlamer/qutepart > Source0: https://github.com/hlamer/qutepart/archive/v%{version}.tar.gz#/qutepart-%{version}.tar.gz … > %prep > %setup0 -q -n qutepart-%{version} %global project qutepart … URL: https://github.com/hlamer/%{project} Source0: %{url}/archive/v%{version}.tar.gz#/%{project}-%{version}.tar.gz … %prep %setup0 -qn%{project}-%{version} * As this package is related to python2, you should use also the respective macros to avoid any confusion. Python2 is still the default but will change in near future to Python3. What about use python3 today? If yes, please adjust BuildRequires, too. https://fedoraproject.org/wiki/Packaging:Python#Macros https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version https://fedoraproject.org/wiki/Packaging:Python#BuildRequires > %build > CFLAGS="%{optflags}" %{__python} setup.py build > > %install > %{__python} setup.py install --skip-build --root %{buildroot} > > %files > %doc LICENSE README.md > %{python_sitearch}/qutepart* %build CFLAGS="%{optflags}" %{__python2} setup.py build %install %{__python2} setup.py install --skip-build --root %{buildroot} %files %license LICENSE %doc README.md %{python2_sitearch}/%{project}* * Please use the %license macro for the license text, see my correction above. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text * Do you plan packages for EPEL or Fedora 20? If yes, that usage of %license macro will be problematic and needs some tweaking. Please let me know if you need further help. I'll update the respective bug fields to keep this open as a review request, see comment #7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review