https://bugzilla.redhat.com/show_bug.cgi?id=1208816 --- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Paulo Andrade from comment #2) > Please change in %files the line: > %{_javadir}/%{name} > to have a %dir prefix. It is usually a good idea to > also add a '/' suffix to make it easier to spot it > is a directory, but with %dir that is redundant. with the newer javapackages-tools/maven-local %dir %{_javadir}/%{name} is no more required (for F22, and rawhide is redundant) > I do not see much of a reason to also add the LICENSE > file to the javadoc package. Sure there may be cases > where one installs only the javadoc packages, but those > should be quite uncommon. But removing it is optional. "License file installed when any subpackage combination is installed." https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing a javadoc sub package should be consider as "independent of any base package" and then include the license files other issues NOTICE file is part of the license and must be installe in both packages with macro %license e.g. %license LICENSE NOTICE java guideline is available here: https://fedoraproject.org/wiki/Packaging:Java https://fedorahosted.org/released/javapackages/doc/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review