https://bugzilla.redhat.com/show_bug.cgi?id=1208873 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Alias| |libskindesignerapi Flags| |fedora-review? --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9408136 Some comments: License texts are no longer in %doc, please move COPYING to %license. %files -n devel This produces a package named "devel" instead of "%{name}-devel". Please omit the -n switch to get the latter. %dir %{_includedir}/%{name}/ %{_includedir}/%{name}/osdelements.h %{_includedir}/%{name}/skindesignerapi.h %{_includedir}/%{name}/skindesignerosdbase.h This can be shrinked as long as you don't have to exclude anything from this directory: %{_includedir}/%{name}/ However, it is your choice. And here is what rpmlint says: $ rpmlint -i -v * devel.x86_64: I: checking devel.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) devel.x86_64: W: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerosdbase.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libskindesignerapi.so A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/osdelements.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. devel.x86_64: W: devel-file-in-non-devel-package /usr/lib64/pkgconfig/libskindesignerapi.pc A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. devel.x86_64: W: devel-file-in-non-devel-package /usr/include/libskindesignerapi/skindesignerapi.h A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. libskindesignerapi.src: I: checking libskindesignerapi.src: E: description-line-too-long C Library which provides the Skindesigner API to other VDR Plugins. VDR Plugins using Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. libskindesignerapi.src: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi.src: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL. libskindesignerapi.x86_64: I: checking libskindesignerapi.x86_64: E: description-line-too-long C Library which provides the Skindesigner API to other VDR Plugins. VDR Plugins using Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. libskindesignerapi.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi-debuginfo.x86_64: I: checking libskindesignerapi-debuginfo.x86_64: I: checking-url http://projects.vdr-developer.org/projects/plg-skindesigner (timeout 10 seconds) libskindesignerapi.spec: I: checking libskindesignerapi.spec: W: invalid-url Source0: libskindesignerapi-0.0.1.tar.bz2 The value should be a valid, public HTTP, HTTPS, or FTP URL. 4 packages and 1 specfiles checked; 2 errors, 9 warnings. Well, rpmlint doesn't detect the devel package as such, so the appropriate issues can be ignored. There only remain the too long description lines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review