[Bug 1208764] Review Request: vagrant-cachier - Vagrant plugin to cache packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1208764



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Don't create vagrant group
  - I don't think that the vagrant group has any meaning for this plugin, so
    the lines:

    Requires(pre): shadow-utils
    getent group vagrant >/dev/null || groupadd -r vagrant

    can be removed.

* rpmlint complains

    ./vagrant-cachier.spec:57: W: macro-in-comment %{gem_instdir}
    vagrant-cachier-doc.noarch: E: non-executable-script /usr/share/vagrant
      /gems/gems/vagrant-cachier-1.2.0/spec/acceptance/sanity_check.bats 0644L
      /usr/bin/env
    vagrant-cachier-doc.noarch: E: non-executable-script /usr/share/vagrant
      /gems/gems/vagrant-cachier-1.2.0/development/Cheffile 0644L /usr/bin/env

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]