https://bugzilla.redhat.com/show_bug.cgi?id=1208816 --- Comment #2 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- Please change in %files the line: %{_javadir}/%{name} to have a %dir prefix. It is usually a good idea to also add a '/' suffix to make it easier to spot it is a directory, but with %dir that is redundant. I do not see much of a reason to also add the LICENSE file to the javadoc package. Sure there may be cases where one installs only the javadoc packages, but those should be quite uncommon. But removing it is optional. The LICENSE and README.md file have DOS style line endings, please correct it, for example: for doc in README.md LICENSE; do sed "s|\r||g" $doc > $doc.new && \ touch -r $doc $doc.new && \ mv $doc.new $doc done I think cors-flowchart.png is more useful than README.md in %doc. Now the bad news :) For the first package it is asking a lot to have the package approved, without running any tests: # Tests don't compile with servlet 3.x, as the mock objects miss some of the # required methods: Please explain why it cannot be adjusted to run tests. Note that tests is the best way to know the package is at least partially functional. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review