https://bugzilla.redhat.com/show_bug.cgi?id=1206639 Kashyap Chamarthy <kchamart@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #6 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- (In reply to Ihar Hrachyshka from comment #5) > Thanks all for review! > > For bad FSF address, I filed in > http://klub.com.pl/bugzilla3/show_bug.cgi?id=316 Thanks. We can proceed with package review. When upstream fixes it, you can make a new build > Unit tests are currently failing in upstream, I've reported a bug: > http://klub.com.pl/bugzilla3/show_bug.cgi?id=317 Thanks. As you noted the SPEC change log, when upstream fixes the bug, you can re-enable it back. > The updated package is at: > - https://ihrachyshka.fedorapeople.org/dibbler-1.0.1-0.RC1.1.fc21.src.rpm > - https://ihrachyshka.fedorapeople.org/dibbler.spec > - https://ihrachyshka.fedorapeople.org/0001-fix-gtest-config-path.patch Nice, `rpmlint` has gone down to 4 benign warnings, so please disregard them. ----------------- $ rpmlint dibbler-1.0.1-0.RC1.1.fc21.src.rpm dibbler.spec dibbler.src: W: spelling-error %description -l en_US stateful -> tasteful, wasteful, fateful dibbler.src: W: spelling-error %description -l en_US autoconfiguration -> auto configuration, auto-configuration, reconfiguration dibbler.src:161: W: macro-in-%changelog %check dibbler.spec:161: W: macro-in-%changelog %check 1 packages and 1 specfiles checked; 0 errors, 4 warnings. ----------------- I issued another scratch build with the new SRPM, just out of practice. It was successful. So, looks good. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review