https://bugzilla.redhat.com/show_bug.cgi?id=1208509 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Souce0 are usable. Ok. Source archive is original (SHA-256: 18401fd2aa73f6ef4b85bb8f6f69c48452b554ab8c4397808c178c36c34beca5). Ok. Summary is Ok. Description is Ok. License verified from README, Makefile.PL, Syntax.pm. Ok. No XS code, noarch BuilArch is Ok. Build-requires are Ok. TODO: Removing write-protected license_syntax.pl in %install section is interactive. Please make the removal forceful or patch Makefile.Pl not to install the file. All test pass. Ok. $ rpmlint perl-License-Syntax.spec ../SRPMS/perl-License-Syntax-0.13-1.fc23.src.rpm ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm perl-License-Syntax.src: W: tag-in-description C License: perl-License-Syntax.src: W: tag-in-description C License: perl-License-Syntax.noarch: W: tag-in-description C License: perl-License-Syntax.noarch: W: tag-in-description C License: 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is dizzy today. Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm se-Syntax-0.13.tar.gz (timeout 10 seconds) . drwxr-xr-x 2 root root 0 Apr 2 17:00 /usr/share/doc/perl-License-Syntax -rw-r--r-- 1 root root 1196 Nov 30 2011 /usr/share/doc/perl-License-Syntax/Changes -rw-r--r-- 1 root root 1563 Oct 5 2011 /usr/share/doc/perl-License-Syntax/README -rw-r--r-- 1 root root 1425 Oct 5 2011 /usr/share/doc/perl-License-Syntax/license_syntax.pl -rw-r--r-- 1 root root 22001 Nov 30 2011 /usr/share/doc/perl-License-Syntax/synopsis.csv -rw-r--r-- 1 root root 4606 Apr 2 16:59 /usr/share/man/man3/License::Syntax.3pm.gz drwxr-xr-x 2 root root 0 Apr 2 16:59 /usr/share/perl5/vendor_perl/License -rw-r--r-- 1 root root 25370 Nov 30 2011 /usr/share/perl5/vendor_perl/License/Syntax.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.2) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(DBD::SQLite) 1 perl(DBI) 1 perl(POSIX) 1 perl(strict) 1 perl(Text::CSV) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm | sort -f | uniq -c 1 perl(License::Syntax) = 0.13 1 perl-License-Syntax = 0.13-1.fc23 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-License-Syntax-0.13-1.fc23.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9399836). Ok. Otherwise the package in line with Fedora and Perl packaging guidelines. Please consider fixing all `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review