[Bug 1206879] Review Request: golang-github-eknkc-amber - Amber is an elegant templating engine for Go Programming Language It is inspired from HAML and Jade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1206879



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
$ rpmlint
/home/jchaloup/rpmbuild/SRPMS/golang-github-eknkc-amber-0-0.1.gitdade3a7.fc20.src.rpm
/home/jchaloup/rpmbuild/RPMS/noarch/golang-github-eknkc-amber-devel-0-0.1.gitdade3a7.fc20.noarch.rpm
golang-github-eknkc-amber.src: W: spelling-error Summary(en_US) templating ->
contemplating, template, tempting
golang-github-eknkc-amber.src: E: summary-too-long C Amber is an elegant
templating engine for Go Programming Language It is inspired from HAML and Jade
golang-github-eknkc-amber.src: W: spelling-error %description -l en_US
templating -> contemplating, template, tempting
golang-github-eknkc-amber.src: E: description-line-too-long C Amber is an
elegant templating engine for Go Programming Language It is inspired from HAML
and Jade
golang-github-eknkc-amber-devel.noarch: W: spelling-error Summary(en_US)
templating -> contemplating, template, tempting
golang-github-eknkc-amber-devel.noarch: E: summary-too-long C Amber is an
elegant templating engine for Go Programming Language It is inspired from HAML
and Jade
golang-github-eknkc-amber-devel.noarch: W: spelling-error %description -l en_US
templating -> contemplating, template, tempting
golang-github-eknkc-amber-devel.noarch: E: description-line-too-long C Amber is
an elegant templating engine for Go Programming Language It is inspired from
HAML and Jade
2 packages and 0 specfiles checked; 4 errors, 4 warnings.

- Summary is too long. You can use "Amber is an elegant templating engine for
Go Programming Language" instead.
- license is OK (MIT) but it is embedded in README.md file. Can you move/copy
the license into LICENSE file?
- remove golang(%{import_path}/amberc) from Provides, amberc folder contains
only one *.go file with "package main". It is not supposed to be package (I
have already update gofed inspect -p to handle this case).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]