[Bug 1064564] Review Request: ahven – a unit testing framework for Ada 95

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1064564



--- Comment #5 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> ---
(In reply to Jeff Layton from comment #3)
> ahven.x86_64: I: enchant-dictionary-not-found sv

That one only says that you don't have a Swedish dictionary installed.

> ahven.x86_64: W: executable-stack /usr/lib64/libahven.so.24
> 
> ...the above is probably worth fixing:
> 
>     https://fedoraproject.org/wiki/Packaging_tricks#Executable_stack

As documented in https://fedoraproject.org/wiki/Packaging:Ada, an executable
stack is normal in Ada because GNAT uses trampolines for pointers to nested
functions.

> ahven-devel.x86_64: W: only-non-binary-in-usr-lib
> 
> ...this appears to be complaining about the GNAT libs. I'll assume they're
> ok, and ignore this. Please do correct this if it's wrong however.

Like in most -devel packages there is a symbolic link in _libdir. Like in all
Ada libraries there are also a number of ALI files. ALI files are
architecture-specific so they can't be moved to /usr/share. I have no idea what
other binary files RPMlint expects to find in a -devel package that would
silence that warning.

> ahven-devel.x86_64: W: hidden-file-or-dir
> /usr/share/doc/ahven/html/.buildinfo
> 
> ...I'd also fix this. Probably simplest to just remove that file after the
> %install stage. It doesn't appear to be necessary in the package.

Well, Sphinx generates that and it didn't seem worth caring about, but OK, I'll
remove it.

> ahven-devel.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/ahven/html/_static/jquery.js
> ahven-devel.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/ahven/html/objects.inv
> ahven-devel.x86_64: W: file-not-utf8 /usr/share/doc/ahven/html/objects.inv
> 3 packages and 0 specfiles checked; 0 errors, 7 warnings. 
> 
> I guess this is the Sphinx problem you referred to? I'll plan to just waive
> the check on this one since it's just the docs.

For jquery.js the argument is the same: If there's a problem with that file,
the place to fix it is in Sphinx.

objects.inv isn't even a text file. If I'm removing .buildinfo I'll simply
remove that one too.

(In reply to Jeff Layton from comment #4)
> Also, Adam's comments in this bug may be a better approach than undefining
> _hardened_build:
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1197501#c5
> 
> ...but I'll leave that for you to decide if it's appropriate.

The general case is more complex than simply using -fPIC everywhere. In this
specific case the testsuite isn't being packaged and doesn't need hardening.
The library itself is hardened.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]