[Bug 1205793] Review Request: signon-kwallet-extension - KWallet integration for Sign-on framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1205793

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
naming: ok

1.  license: NOT ok, src files appear to be GPLv2+

scriptlets: ok

macros: ok

%files/ownership: ok  (just fixed signon to properly own libdir/extensions)

builds/installs ok


The only item I found was the licensing, should be:
License: GPLv2+
please fix prior to building.


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]