[Bug 1196925] Review Request: jsemver - A Java implementation of the Semantic Versioning Specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1196925



--- Comment #5 from Alec Leamas <leamas.alec@xxxxxxxxx> ---
Looks basically OK. Issues:

  -  Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-poms/jsemver
     Seems like a bug in xmvn-install (?). For the time being the
     easy fix might be to claim the directory using %dir.
  -  Please  remove all class and .jar files in %prep to make sure no
     prebuilt binaries are used in the build process. This is not
     strictly required by the GL in this case since the upstream is
     "clean" in this sense, but it's a god habit to avoid surprises
     when upstream is updated.
  -  PLease dont add the docs to both the -javadoc and the main package [1]

[1]:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#DuplicateFiles

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]