[Bug 1190269] Review Request: openstack-barbican - Secrets as a Service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1190269



--- Comment #3 from Haïkel Guémar <karlthered@xxxxxxxxx> ---
Sorry for the delay:
1. python-barbican contains no python modules, that's due to missing
BuildRequires. By adding oslo stuff, I was able to fix that issue.
https://github.com/openstack/barbican/blob/stable/juno/requirements.txt
=> blocker as it prevents barbican to be built properly in a chrooted env.

2. use python versioned macros %{__python2} and %{__python2_sitelib}
For EL6, here's a fallback macro
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?__python2:        %global __python2 /usr/bin/python2}
%{!?python2_sitelib:  %global python2_sitelib %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif

3.we are dropping PBR patches starting kilo, so you may just drop it too and
add Requires: python-pbr to python-barbican

4.drop the %clean section not required for EL6+ and supported Fedora

5. drop the %defattr, RPM has sensible defaults for EL6+ 

6.minor but I would prefer using an openstack url rather than the cloudkeep one


Please fix and set me in the needinfo flag when you're done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]