Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gpsdrive - A GPS based navigation tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240243 ------- Additional Comments From jeremy@xxxxxxxxxxxxxxx 2007-05-20 20:43 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistent macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: eaa52cb220f3d10312a1046dd47126bb gpsdrive-2.09.tar.gz (upstream) eaa52cb220f3d10312a1046dd47126bb rpmbuild/SOURCES/gpsdrive-2.09.tar.gz OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. (not needed) OK - Packages %doc files don't affect runtime. OK - Spec has needed ldconfig in post and postun OK - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. ISSUE (1) - rpmlint output. SHOULD Items: OK - Should build in mock. OK - Should function as described. (program launched ok) OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version SHOULD Items: OK - Should build in mock. OK - Should function as described. (program launched ok) OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version Issues: 1. rpm lint output E: gpsdrive incorrect-locale-el /usr/share/locale/gr/LC_MESSAGES/gpsdrive.mo It appears that gpsdrive is shipping the Greek messages using the ISO country code for Greece ('gr') instead of the ISO 639 locale code for the greek language ('el'). I would consider this an upstream bug, but if you want to fix it in the rpm that's fine and then lodge the issue upstream that would allow the Greek language Fedora users to use gpsdrive. I don't know much about I18N in C programs, but would moving the gr.po and gr.pmo files to el.po and el.pmo respectively after the man page conversion to UTF-8 fix this issue? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review