[Bug 1167076] Review Request: jlibrtp - Java library for the Real-Time Transport Protocol (RTP)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1167076



--- Comment #8 from Michael Simacek <msimacek@xxxxxxxxxx> ---
> - You're using %mvn_artifact and %mvn_install therefore, you should use
>   %files -f .mfiles
>   instead of specifying the JAR and metadata by hand.

I probably wasn't very clear. You shouldn't specify path to metadata manually,
that's what .mfiles are for. .mfiles are filelists generated by our tooling
(%mvn_install in this case) that contain the entries for directories and files
that were installed by it. The -f option tells rpmbuild to read the entries
from that file. You only need to explicitly list files that you manually
installed into the buildroot. So your files section for the main package should
look like this:
%files -f .mfiles
%license src/org/%{name}/LICENSE.txt

Nothing else is needed. The chmod in %install section is also unnecessary as
.mfiles contain correct ownership specification. The reason why I insist on
this is that when you install things using automatic tools, but then enumerate
the installed files by hand, it may easily go out of sync and your package
would break when we change our tooling. This has already happened for a lot of
packages after we changed the way how we represent Maven metadata.

> - Requires on java is automatically generated, it needn't be specified
>   manually

Still applies. "java" is virtual provides that pulls in complete JRE. In Fedora
there is a stripped down version of JRE called java-headless, that doesn't
contain graphical stuff and is intended to be used on servers. Libraries and
packages that don't need graphics/sound support shouldn't require "java", but
"java-headless"
When using %mvn_install the requires on java-headless are generated
automatically, so just remove "java" from Requires.

> - The test and demo directories are empty, don't package them

Still applies, there's no need to pollute the system with empty directories.
(And if they were non-empty, tests shouldn't be installed anyway)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]