https://bugzilla.redhat.com/show_bug.cgi?id=1194798 Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #11 from Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - No %config files under /usr. Note: %config(noreplace) /usr/share/GeoIP/GeoIP.dat See: http://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/philipp/fedora/GeoIP- GeoLite-data/review-GeoIP-GeoLite-data/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [-]: License file installed when any subpackage combination is installed. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/GeoIP(geoipupdate- cron6, GeoIP-data) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [-]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [-]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu) See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: GeoIP-GeoLite-data-2015.02-1.fc23.noarch.rpm GeoIP-GeoLite-data-extra-2015.02-1.fc23.noarch.rpm GeoIP-GeoLite-data-2015.02-1.fc23.src.rpm GeoIP-GeoLite-data.noarch: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.noarch: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/share/GeoIP/GeoIP.dat GeoIP-GeoLite-data.noarch: W: no-documentation GeoIP-GeoLite-data-extra.noarch: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data-extra.noarch: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data-extra.noarch: W: no-documentation GeoIP-GeoLite-data.src: W: spelling-error Summary(en_US) geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.src: W: spelling-error %description -l en_US geolocation -> echolocation, collocation, allocation GeoIP-GeoLite-data.src: W: file-size-mismatch GeoIPASNumv6.dat.gz = 2378270, http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNumv6.dat.gz = 2395433 GeoIP-GeoLite-data.src: W: file-size-mismatch GeoIPASNum.dat.gz = 2086766, http://download.maxmind.com/download/geoip/database/asnum/GeoIPASNum.dat.gz = 2103287 GeoIP-GeoLite-data.src: W: file-size-mismatch GeoLiteCityv6.dat.gz = 12209168, http://geolite.maxmind.com/download/geoip/database/GeoLiteCityv6-beta/GeoLiteCityv6.dat.gz = 12523932 GeoIP-GeoLite-data.src: W: file-size-mismatch GeoLiteCity.dat.gz = 11949432, http://geolite.maxmind.com/download/geoip/database/GeoLiteCity.dat.gz = 12263571 GeoIP-GeoLite-data.src: W: file-size-mismatch GeoIPv6.dat.gz = 690323, http://geolite.maxmind.com/download/geoip/database/GeoIPv6.dat.gz = 712061 GeoIP-GeoLite-data.src: W: file-size-mismatch GeoIP.dat.gz = 436680, http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz = 455464 3 packages and 0 specfiles checked; 0 errors, 15 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review