[Bug 1202604] Review Request: python-sscg - Self-signed Certificate Generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1202604



--- Comment #19 from Stephen Gallagher <sgallagh@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #18)
> Packaging looks good, the comments above were all addressed, rpmlint output
> is OK.
> 
> sscg.noarch: W: no-documentation
> sscg.noarch: W: no-manual-page-for-binary sscg
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> Package is APPROVED.
> 

Thank you for the very thorough review, Zbigniew!


> 
> I found another small issue, which I think should be resolved before the
> package is submitted:
> 
> DEFAULT_CA_CERT = "/etc/pki/ca-trust/source/anchors", but
> /etc/pki/ca-trust/source/anchors is a directory, owned by ca-certificates.
> So renaming the tempfile fails:

Well, I was envisioning that in real-world usage, this would normally be
operated by the root user, but I suppose that may not actually be true. I'll
change the default location to match the directory where the service
certificate is placed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]