[Bug 1148657] Review Request: python-astor - Read/rewrite/write Python ASTs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1148657

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Some initial comments:

According to PKG-INFO, it also builds with Python 3, and that one will become
the default next time in Fedora:
http://fedoraproject.org/wiki/Changes/Python_3_as_Default#Current_status
So I recommend to either build both versions, or only the Python 3 one,
depending on your needs for python-hy.

python-devel is deprecated, use python2-devel or python3-devel instead:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

LICENSE is no longer part of %doc, we need it in %license:
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image

There is a stray whitespace character in line 13 of your spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]