https://bugzilla.redhat.com/show_bug.cgi?id=905304 --- Comment #110 from Steve Jenkins <steve@xxxxxxxxxxxxxxxx> --- (In reply to Andrew J. Schorr from comment #109) Hi, Andy. Thanks for the great feedback. > I have a few questions about the packaging: > > 1. Why does this rpm install both /etc/rc.d/init.d/opendmarc and > /usr/lib/systemd/system/opendmarc.service? Shouldn't > /etc/rc.d/init.d/opendmarc be removed? I believe I fixed this a couple of versions ago while cleaning up (what I hope to be) all the systemd vs. SysV stuff when I consolidated into a shared spec file and used conditionals. Do lines 99 thru 122 here address this?: https://github.com/stevejenkins/OpenDMARC-Fedora/blob/15c0d9a948baee1ef1b5c20c212a3bf6187b42d1/SPECS/opendmarc.spec > 2. The opendmarc binary requires libmilter. Why doesn't the spec file say > "Requires: sendmail-milter"? This was mentioned in Comment #27, but I don't > see it in the spec file. Good catch added. See line 14 in the above link. > > 3. The opendmarc binary is linked against libbsd. So why is libbsd specified > as "BuildRequires:" instead of "Requires:"? Another great question. :) See also line 14 in the above link. Feel free to peek through that version of the spec file and see if anything else looks out of place. I'll hold off a bit before I push those changes and rebuild. Thanks! Steve -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review