https://bugzilla.redhat.com/show_bug.cgi?id=1070406 Rex Dieter <rdieter@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #14 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- Naming: ok, but... small suggestion: 1. I'd prefer this pkg follow upstream name and just call it 'signon'. We can then choose to make signon-qt5 subpkgs from it. Not a blocker, especially if you feel strongly otherwise. 2. 8.57-1 update missed %changelog entry, please fix prior to doing official builds 3. SHOULD do out-of-src tree build, something like: %build mkdir build pushd build ... %{qmake_qt5} .. ... popd 4. SHOULD fix or document this explicit -devel dependency: Requires: glib2-devel%{?_isa} (either fix by adding a pkg-config dependency or document in a comment why that would be insufficient and needed anyway) License: OK macros: ok scriptlets: ok Not strict blockers, though ideally I'd still like to see this named 'signon' instead (see item 1), in which case, I'd like to see one more update with that implemented. (In case you disagree with renaming), consider this APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review