https://bugzilla.redhat.com/show_bug.cgi?id=1206067 Chandan Kumar <chkumar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chkumar@xxxxxxxxxx --- Comment #1 from Chandan Kumar <chkumar@xxxxxxxxxx> --- This is un-official review of the package. + License is "ASL 2.0" which is valid and its license text is installed in LICENSE file. Suggestions: [1.] Group tag is optional in Fedora and is only needed if you want this package to be built for EPEL5. See http://fedoraproject.org/wiki/EPEL:Packaging#Group_tag. You can remove Group tag from both package and sub-package. [2.] Change the URL from launchpad to pypi, URL: https://pypi.python.org/pypi/oslo.log [3.] Since this package requires python-six >=1.9.0, please change Requires to: Requires: python-six >= 1.9.0 [4.] Description of the package is not clear. Please add some more information about the package. [5.] rpmlint on all generated rpms and specfile give result: python-oslo-log-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-oslo-log-doc/html/_static/jquery.js 3 packages and 1 specfiles checked; 0 errors, 1 warnings. => It can be fixed by adding dos2unix doc/build/html/_static/jquery.js in %install section but this will require you to add in spec file BuildRequires: dos2unix [6.] From mock build.log, ImportError: No module named oslo_context Since, python-oslo-context package is not available in Fedora, Once it is availablle, Please add this package in BuildRequires in the spec file. [7.] in %files section, please include other files also present in the python package tarball. %doc AUTHORS CONTRIBUTING.rst README.rst PKG-INFO ChangeLog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review