Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lcdpro - LCDproc displays real-time system information on a 20x4 backlit LCD https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236849 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-05-19 21:14 EST ------- Just a few notes, before a more comprehensive review: - version 0.5.2 has been released by upstream a couple of weeks ago. any reason to not update the rpm, too ? - the following quote from the spec does not seem right: %makeinstall make install DESTDIR=$RPM_BUILD_ROOT Since the whole ./configure process is done twice, it looks like the first line is just a leftover from a previous version or something... - I'd say the file CREDITS should also be included as %doc - I get a lot of warnings during configure: checking for libg15render.h... no configure: WARNING: The g15driver needs libg15render.h checking for main in -lirman... no configure: WARNING: The irman driver needs the irman library. checking for main in -llirc_client... no configure: WARNING: The lirc driver needs the lirc client library checking for vga.h... no configure: WARNING: The svga driver needs vga.h and vgagl.h checking for main in -lftdi... no configure: WARNING: The ula200 driver needs the ftdi library ... and others. They look to me like missing build requires, or at least screaming for a couple more packages needed. I do not know about some of them, but lirc at least is available in Fedora, any reason to not use it? - rpmlint has a small cosmetic complaint: W: lcdproc mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) - however rpmlint of lcdproc is a bit more serious: W: lcdproc service-default-enabled /etc/rc.d/init.d/lcdproc --> please fix that, a one line sed to patch the script should do it W: lcdproc no-reload-entry /etc/rc.d/init.d/lcdproc --> can be ignored, but it would be nice to update the initscript instead W: lcdproc service-default-enabled /etc/rc.d/init.d/LCDd W: lcdproc no-reload-entry /etc/rc.d/init.d/LCDd -->same as above - the postuninstall scriptlet is not particulary friendly. Shouldn't the service be stopped prior to deleting it? - I did not look very attentive, but there seem to exist some additional docs and programs/examples available (and built by the make scripts). Any particular reason to not include those (eventually as separate packages) ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review