[Bug 1204614] Review Request: gofed - Tool for development of golang devel packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1204614

Ondrej Oprala <ooprala@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Ondrej Oprala <ooprala@xxxxxxxxxx> ---
[ ]: Changelog in prescribed format.
>>> OK
[ ]: %config files are marked noreplace or the reason is justified.
     Note: No (noreplace) in %config /usr/share/gofed/config/gofed.conf
>>> OK
[ ]: Package does not generate any conflict.
>>> OK

gofed.x86_64: W: unstripped-binary-or-object /usr/share/gofed/parseGo
also fixed :)

fedora-review also ran the Python plugin this time:
Python:
[ ]: Python eggs must not download any dependencies during the build process.
>>> OK
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
>>> OK
[ ]: Package meets the Packaging Guidelines::Python
>>> OK
[x]: Binary eggs must be removed in %prep

Thanks, I don't see any further issue.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]