https://bugzilla.redhat.com/show_bug.cgi?id=1166752 --- Comment #2 from Joel Uckelman <uckelman@xxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1) > One src.rpm/spec per review ticket, please. Should I open a new ticket for the mingw package, then? > That would also make it trivial to point the optional fedora-review tool at > this ticket: fedora-review -b 1166752 > > It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest > files, builds test-packages and runs lots of checks on them. Not limited to > rpmlint. Give it a try yourself. > > > > Summary: Not the worst forensics regexp engine > > Funny. :) Not everyone's cup of tea, though as a caveat. > > > > Name: liblightgrep > > Group: Development/Libraries > > The Group tag for runtime library base packages has been "System > Environment/Libraries" for many years. Nowadays, the tag is optional for > most target dists: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > Fixed. > > %package devel > > Only if you want/need the Group tag, for this subpackage it would be > "Development/Libraries". ;-) Fixed. > > # FIXME: force -O3? > > %configure --enable-shared --disable-static > > An answer to that question may be found here: > https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags I believe I can provide benchmarks showing that -O3 makes a difference here for our library. I'll return with those later. > > > %files devel > > %doc > > An empty %doc does nothing and may be deleted safely (-> no side-effects!). Fixed. > %{_libdir}/pkgconfig/lightgrep.pc Was there a comment associated with this that got cut off? > > Length: 155523804 (148M) [application/x-rpm] This made me notice that we're packaging a lot of test data which we don't need to be---the source package should be about 1/10 the size once I've fixed that. > Does anything use this library API yet? An unused library alone isn't too > useful. Yes. The big thing is bulk_extractor, which is an open-source forensics toolkit: http://www.forensicswiki.org/wiki/Bulk_extractor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review