[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> ---
(In reply to Dave Love from comment #7)
> (In reply to Antonio Trande from comment #4)
> > @Dave
> > 
> > Why Make destination directory is $RPM_BUILD_ROOT/usr ?
> 
> It saved re-writing the makefile which doesn't use DESTDIR as normal.
> I didn't think a comment was necessary, but maybe it is.

DEST_DIR            ?= /usr/local
LIB_DIR                = $(BOOST_LIB_DIR)
INC_DIR                = $(BOOST_INC_DIR)
BIN_DIR                = $(DEST_DIR)/bin
MAN_DIR                = $(DEST_DIR)/man/man1

It considers a manual local installation under /usr/local/ directory, but i
think it's better a Makefile patching in order to use right directories for the
packaging; so something like:

...

%build
# This changed somewhere between EPEL6 and Fedora 21.
## Set Boost's library directories
if [ -f %{_libdir}/libboost_thread-mt.so ]; then
  echo "BOOST_LIB_SUFFIX = -mt" >> make.config
else
  echo "BOOST_LIB_SUFFIX = " >> make.config
fi
echo "BOOST_INC_DIR=%{_includedir}/boost" >> make.config
echo "BOOST_LIB_DIR=%{_libdir}" >> make.config

## Set Make
sed -e 's|+= -O3|+= %{optflags}|g' -i makefile
sed -e 's|?= /usr/local|= $(DESTDIR)|g' -i makefile
sed -e 's|$(DEST_DIR)/bin|$(DEST_DIR)%{_bindir}|g' -i makefile
sed -e 's|$(DEST_DIR)/man/man1|$(DEST_DIR)%{_mandir}/man1|g' -i makefile

export DEBUG=0
make %{?_smp_mflags}


%install
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'

...

Unless you want to package in EPEL5, you dont need %clean section.
Also, use %license for LICENSE_1_0.txt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]