[Bug 1204777] Review Request: python3-pkgversion-macros - Convenience macros for Fedora/EPEL Python 3 packages building

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1204777



--- Comment #8 from Matej Stuchlik <mstuchli@xxxxxxxxxx> ---
(In reply to Aurelien Bompard from comment #7)
> Ah, mid-air collision. I was doing the review on my computer, here's a
> summary of what I found:
> - mixed-use-of-spaces-and-tabs (Source1 is indented with spaces)
> - Adding "Requires: rpm" would make sense and fix a directory ownership
>   problem.
> - (minor) Please also escape the %python3_other_pkgversion macro in the
>   commented lines, even comments are interpreted by RPM and may create a
>   (harmless) error message.

Thanks you! Good points, I'll fix these.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]