https://bugzilla.redhat.com/show_bug.cgi?id=1205489 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx Flags| |fedora-review- --- Comment #1 from Haïkel Guémar <karlthered@xxxxxxxxx> --- 1. doesn't build due to missing BuildRequires: python-sphinx 2. if you use %autosetup, you don't need to use %patch as the former will apply it for you. I suggest using -S git option as it allows you to manage your patches with git (the standard for RDO btw) 3.use %{_sharedstatedir} instead of /var/lib 4. according guidelines, you shouldn't deploy web applications into /var/www but %{_datadir}/%{name} 5. sources shouldn't be put in /usr/src (non-standard), are they required ? If they're not, I'd suggest to drop them. 6.missing Requires: python-netaddr, python-pexpect -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review