[Bug 1200520] Review Request: python-debtcollector - A collection of Python deprecation patterns and strategies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1200520

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #7 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

+ Package built successfully in rawhide mock (x86_64)

+ rpmlint on all generated rpms give result
python-debtcollector-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-debtcollector-doc/html/_static/jquery.js
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

=> I actually don't see any benefit fixing this but if you want you can do in
%install as
dos2unix doc/build/html/_static/jquery.js

but this will require you to add in spec file 
BuildRequires: dos2unix

+ Source verified with upstream as (sha256sum)
source rpm tarball:
64cf1ab9bacbdda8c83a569349f2a91211a890973e0119514a9b7bf34518373e
upstream tarball:
64cf1ab9bacbdda8c83a569349f2a91211a890973e0119514a9b7bf34518373e

+ License is "ASL 2.0" which is valid and its license text is installed in
LICENSE file.

Suggestions:
1) I see build.log showing some tracebacks while building documentation. This
mean you are missing some packages. For this package you should add in spec
BuildRequires: python-six
BuildRequires: python-oslo-utils

submit new package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]