https://bugzilla.redhat.com/show_bug.cgi?id=1204898 --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Issues: - It is better to use %post -p, see https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries - COPYING file is not installed. It should be installed using %license. See https://fedorahosted.org/fpc/ticket/411#comment:11 for a trick if EPEL5-6 compat is required. - I think the License field is wrong. COPYING seems to be BSD. - NEWS, README look like candidates for %doc. - .pc file looks wrong, most fields are empty: prefix= exec_prefix= libdir= includedir= Name: libntirpc Description: New Transport Independent RPC Library Requires: Version: Libs: -L -lintirpc Cflags: -I/ntirpc - libntirpc.src:61: W: macro-in-comment %{buildroot} Please silence this with by doubling the percent sign. - -devel subpackage has no dependency on the main package. It should Require it, in the same %{_isa} and %{version}. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review