[Bug 1205194] Review Request: mingw-libepoxy - MinGW Windows libepoxy library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1205194

Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #5 from Erik van Pienbroek <erik-fedora@xxxxxxxxxxxxxxx> ---
$ rpmlint mingw-libepoxy.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw-libepoxy-1.2-2.fc22.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw32-libepoxy-1.2-2.fc22.noarch.rpm
mingw64-libepoxy-1.2-2.fc22.noarch.rpm 
mingw32-libepoxy.noarch: W: no-documentation
mingw64-libepoxy.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


$ rpm --query --requires mingw32-libepoxy
mingw32(kernel32.dll)
mingw32(msvcrt.dll)
mingw32-crt
mingw32-filesystem >= 95
mingw32-pkg-config
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-libepoxy
mingw64(kernel32.dll)
mingw64(msvcrt.dll)
mingw64-crt
mingw64-filesystem >= 95
mingw64-pkg-config
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --provides mingw32-libepoxy
mingw32(libepoxy-0.dll)
mingw32-libepoxy = 1.2-2.fc22

$ rpm --query --provides mingw64-libepoxy
mingw64(libepoxy-0.dll)
mingw64-libepoxy = 1.2-2.fc22


$ wget --quiet
https://github.com/anholt/libepoxy/archive/v1.2/libepoxy-1.2.tar.gz -O - |
md5sum
12d6b7621f086c0c928887c27d90bc30  -
$ md5sum libepoxy-1.2.tar.gz 
12d6b7621f086c0c928887c27d90bc30  libepoxy-1.2.tar.gz


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
    to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal

The rpmlint warning can be avoided by adding %doc README.md to both subpackages
but this is a minor issue

======================================================
 The package mingw-libepoxy is APPROVED by epienbro
======================================================

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]