[Bug 1203105] Review Request: rubygem-amq-protocol - AMQP 0.9.1 encoder & decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203105

Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktdreyer@xxxxxxxxxxxx



--- Comment #7 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
A couple nice-to-haves:

- Remove the "Generated from ..." comment added by gem2rpm; this will get stale
over time.

- Use the %license macro for %{gem_instdir}/LICENSE

- You can delete %{gem_instdir}/%{gem_name}.gemspec immediately after
%gem_install, since you're already shipping %{gem_spec}. Like this:

  %build
  gem build %{gem_name}.gemspec
  %gem_install

  # Remove unnecessary gemspec file
  rm .%{gem_instdir}/%{gem_name}.gemspec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]