https://bugzilla.redhat.com/show_bug.cgi?id=1203105 --- Comment #5 from Lon Hohberger <lhh@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - gems should require rubygems package Note: Requires: rubygems missing in rubygem-amq-protocol-doc See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems - %doc subpackage should have: Requires: %{name} = %{version}-%{release} ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". lon: This is how upstream shipped these files; license is MIT [!]: License file installed when any subpackage combination is installed. lon: would be resolved by Requires: %{name} = %{version}-%{release} [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc lon: would be resolved by Requires: rubygems [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [x]: Binary eggs must be removed in %prep Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files lon: not a blocker; font in doc [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem- amq-protocol-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. lon: not a blocker [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [!]: Gem should use %gem_install macro. [!]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %exclude /usr/share/gems/cache/amq-protocol-1.9.2.gem, /usr/share/gems/specifications/amq-protocol-1.9.2.gemspec [x]: Gem package should exclude cached Gem. [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-amq-protocol-1.9.2-1.fc21.noarch.rpm rubygem-amq-protocol-doc-1.9.2-1.fc21.noarch.rpm rubygem-amq-protocol-1.9.2-1.fc21.src.rpm rubygem-amq-protocol.noarch: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization rubygem-amq-protocol-doc.noarch: E: non-executable-script /usr/share/gems/gems/amq-protocol-1.9.2/profiling/stackprof/body_framing_with_2k_payload.rb 0644L /usr/bin/env rubygem-amq-protocol-doc.noarch: E: non-executable-script /usr/share/gems/gems/amq-protocol-1.9.2/benchmarks/pure/body_framing_with_256k_payload.rb 0644L /usr/bin/env rubygem-amq-protocol-doc.noarch: E: script-without-shebang /usr/share/gems/gems/amq-protocol-1.9.2/amq-protocol.gemspec rubygem-amq-protocol-doc.noarch: E: non-executable-script /usr/share/gems/gems/amq-protocol-1.9.2/benchmarks/pure/body_framing_with_2k_payload.rb 0644L /usr/bin/env rubygem-amq-protocol.src: W: spelling-error %description -l en_US deserialization -> serialization, materialization, denationalization 3 packages and 0 specfiles checked; 4 errors, 2 warnings. lon: warnings are okay. The 4 errors are noise; primarily from test package Requires -------- rubygem-amq-protocol (rpmlib, GLIBC filtered): ruby(rubygems) rubygem-amq-protocol-doc (rpmlib, GLIBC filtered): /usr/bin/env rubygem-amq-protocol Provides -------- rubygem-amq-protocol: rubygem(amq-protocol) rubygem-amq-protocol rubygem-amq-protocol-doc: rubygem-amq-protocol-doc Source checksums ---------------- https://rubygems.org/gems/amq-protocol-1.9.2.gem : CHECKSUM(SHA256) this package : 79e018cb1a3522967525973ae04d40884620e8d4adca02afeb710f00643a84be CHECKSUM(SHA256) upstream package : 79e018cb1a3522967525973ae04d40884620e8d4adca02afeb710f00643a84be Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review