https://bugzilla.redhat.com/show_bug.cgi?id=1204898 --- Comment #3 from Kaleb KEITHLEY <kkeithle@xxxxxxxxxx> --- > - ldconfig called in %post and %postun if required. > Note: /sbin/ldconfig not called in libntirpc > See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries Fixed, it was an oversight > > - Summary and description for -devel subpackage usually just say something like: > Summary : Development headers for %{name} > Description : > Development headers and auxiliary files for developing with %{name}. Fixed > > - Consider using %autosetup instead of %setup + %patch. For one patch? Docs say %autosetup is for spec files with lots of patches. Eventually the patch should go away. > > - make %{?_smp_mflags} || make %{?_smp_mflags} || make > ??? fixed > > - The build system seems "suboptimal". Why does it need to be patched in spec file, *and* then fixed up afterwards in %install? 1) The patch and the fixups should eventually go away. 2) Obviously I can't patch the ../src/CMakeLists.txt to hard code install to /usr/lib64 as that will break on 32-bit archs. I could create two patches and patch accordingly on 32- and 64-bit; that seems worse IMO. 3) I haven't found the correct fix to the top-level CMakeLists.txt to install the .pc file in /usr/lib{,64}/pkgconfig. Suggested fixes are welcome. 4) The patch changes the library from a static lib to a shlib AND changes the install location from /bin to /lib. I could remove the change of the installed location but I'd still have a patch and I'd still have a fixup. > > - There are tests in the upstream tarball. Can they be run in %check? I prefer not to at this time. They aren't being run when built bundled in nfs-ganesha. I've never run them. Perhaps the upstream maintainer will decide to do that once he is sponsored as a packager and takes over the package. New spec and SRPM at the above location. Koji scratch builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=9312202 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review