https://bugzilla.redhat.com/show_bug.cgi?id=1155793 --- Comment #10 from Christopher Meng <i@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) ----------------- hyperrogue-55/hyper.cpp Unknown or generated -------------------- hyperrogue-55/achievement.cpp hyperrogue-55/achievement.h hyperrogue-55/cell.cpp hyperrogue-55/classes.cpp hyperrogue-55/game.cpp hyperrogue-55/geometry.cpp hyperrogue-55/graph.cpp hyperrogue-55/heptagon.cpp hyperrogue-55/hyperpoint.cpp hyperrogue-55/language-cz.cpp hyperrogue-55/language-pl.cpp hyperrogue-55/language-tr.cpp hyperrogue-55/language.cpp hyperrogue-55/polygons.cpp [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: hyperrogue-5.5a-1.fc23.x86_64.rpm hyperrogue-5.5a-1.fc23.src.rpm hyperrogue.x86_64: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue-like, Rogelio hyperrogue.x86_64: W: incoherent-version-in-changelog 4.5-1 ['5.5a-1.fc23', '5.5a-1'] hyperrogue.x86_64: E: incorrect-fsf-address /usr/share/doc/hyperrogue/COPYING hyperrogue.x86_64: E: non-standard-executable-perm /usr/bin/hyperrogue 0775L hyperrogue.x86_64: W: no-manual-page-for-binary hyperrogue hyperrogue.x86_64: E: invalid-appdata-file /usr/share/appdata/hyperrogue.appdata.xml hyperrogue.src: W: spelling-error Summary(en_US) roguelike -> rogue like, rogue-like, Rogelio 2 packages and 0 specfiles checked; 3 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- hyperrogue (rpmlib, GLIBC filtered): dejavu-sans-fonts libGL.so.1()(64bit) libSDL-1.2.so.0()(64bit) libSDL_gfx.so.15()(64bit) libSDL_mixer-1.2.so.0()(64bit) libSDL_ttf-2.0.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- hyperrogue: appdata() appdata(hyperrogue.appdata.xml) application() application(hyperrogue.desktop) hyperrogue hyperrogue(x86-64) Source checksums ---------------- http://www.roguetemple.com/z/hyper/hyperrogue-55.zip : CHECKSUM(SHA256) this package : 6390607b827d69410843cd63c9f29b1c2e8fa31adbcf37914131b17662a03775 CHECKSUM(SHA256) upstream package : 6390607b827d69410843cd63c9f29b1c2e8fa31adbcf37914131b17662a03775 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -rvn hyperrogue-5.5a-1.fc21.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ------------------------Manul Review Start------------------------ 1. This package was compiled without proper flags: Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Cf4TIz + umask 022 + cd /builddir/build/BUILD + cd hyperrogue-55 + make -j4 g++ hyper.cpp -o hyper -lSDL -lSDL_ttf -lSDL_mixer -DFHS -Wall -g -lSDL_gfx -lGL -O3 In file included from hyper.cpp:73:0: graph.cpp:127:109: warning: narrowing conversion of '3503345919u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] int skincolors[] = { 7, 0xD0D0D0FF, 0xEFD0C9FF, 0xC77A58FF, 0xA58869FF, 0x602010FF, 0xFFDCB1FF, 0xEDE4C8FF }; ^ graph.cpp:127:109: warning: narrowing conversion of '4023437823u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:127:109: warning: narrowing conversion of '3346684159u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:127:109: warning: narrowing conversion of '2777180671u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:127:109: warning: narrowing conversion of '4292653567u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:127:109: warning: narrowing conversion of '3991193855u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:128:121: warning: narrowing conversion of '2355645183u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] int haircolors[] = { 8, 0x686868FF, 0x8C684AFF, 0xF2E1AEFF, 0xB55239FF, 0xFFFFFFFF, 0x804000FF, 0x502810FF, 0x301800FF }; ^ graph.cpp:128:121: warning: narrowing conversion of '4074876671u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:128:121: warning: narrowing conversion of '3042064895u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:128:121: warning: narrowing conversion of '4294967295u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:128:121: warning: narrowing conversion of '2151678207u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:129:97: warning: narrowing conversion of '3221225727u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] int dresscolors[] = { 6, 0xC00000FF, 0x00C000FF, 0x0000C0FF, 0xC0C000FF, 0xC0C0C0FF, 0x202020FF }; ^ graph.cpp:129:97: warning: narrowing conversion of '3233808639u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:129:97: warning: narrowing conversion of '3233857791u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:130:97: warning: narrowing conversion of '3233857791u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] int swordcolors[] = { 6, 0xC0C0C0FF, 0xFFFFFFFF, 0xFFC0C0FF, 0xC0C0FFFF, 0x808080FF, 0x202020FF }; ^ graph.cpp:130:97: warning: narrowing conversion of '4294967295u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:130:97: warning: narrowing conversion of '4290822399u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:130:97: warning: narrowing conversion of '3233873919u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp:130:97: warning: narrowing conversion of '2155905279u' from 'unsigned int' to 'int' inside { } is ill-formed in C++11 [-Wnarrowing] graph.cpp: In function 'void selectEyeGL(int)': graph.cpp:266:18: warning: narrowing conversion of '((double)vid.videopar::yres / (double)vid.videopar::xres)' from 'double' to 'GLfloat {aka float}' inside { } is ill-formed in C++11 [-Wnarrowing] vid.yres * 1./vid.xres, 0, 0, 0, ^ graph.cpp:282:69: warning: narrowing conversion of '- vid.videopar::alpha' from 'ld {aka long double}' to 'GLfloat {aka float}' inside { } is ill-formed in C++11 [-Wnarrowing] GLfloat mat[16] = {sc,0,0,0, 0,-sc,0,0, 0,0,-1,0, 0,0,-vid.alpha,1}; ^ In file included from hyper.cpp:63:0: language.cpp: In function 'void initlanguage()': language.cpp:297:6: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without void initlanguage() { ^ + exit 0 Please use %optflags for compile and %__global_ldflags for linking 2. No install rule, that's ok, but please install with "install" command instead of cp. For instance: mkdir -p %{buildroot}%{_datadir}/pixmaps/ cp -p %{SOURCE3} %{buildroot}%{_datadir}/pixmaps/%{name}-icon.png -> mkdir -p %{buildroot}%{_datadir}/pixmaps/ install -pDm644 %{SOURCE3} %{buildroot}%{_datadir}/pixmaps/%{name}-icon.png 644 for normal files, 755 for executables. BTW, I think hyperrogue.png is good, you don't need to append "-icon" there. 3. New guidelines here, please check: (1). http://fedoraproject.org/wiki/Packaging:AppData (2). http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text 4. Tell upstream to update the license text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review